[core] create FrequencyCalculator class for sender / receiver frequency calculation. #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| private: | ||
| long long counted_elements; |
There was a problem hiding this comment.
warning: use default member initializer for 'counted_elements' [modernize-use-default-member-init]
ecal/core/src/util/frequency_calculator.h:53:
- : counted_elements(0)
+ :
Suggested change
| long long counted_elements; | |
| long long counted_elements{0}; |
| long long counted_elements; | ||
| time_point first_tick; | ||
| time_point last_tick; | ||
| double previous_frequency; |
There was a problem hiding this comment.
warning: use default member initializer for 'previous_frequency' [modernize-use-default-member-init]
ecal/core/src/util/frequency_calculator.h:56:
- , previous_frequency(0.0)
+ ,
Suggested change
| double previous_frequency; | |
| double previous_frequency{0.0}; |
FlorianReimold
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.