clang tidy ecal/core/src/service

eclipse-ecal · Nov 10, 2023 · 558bfb1 · 558bfb1
1 parent 5cd4c7c
commit 558bfb1
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/ecal/core/src/service/ecal_clientgate.h b/ecal/core/src/service/ecal_clientgate.h
@@ -70,11 +70,11 @@ namespace eCAL
   protected:
     static std::atomic<bool>    m_created;
 
-    typedef std::set<CServiceClientImpl*> ServiceNameServiceImplSetT;
+    using ServiceNameServiceImplSetT = std::set<CServiceClientImpl *>;
     std::shared_timed_mutex     m_client_set_sync;
     ServiceNameServiceImplSetT  m_client_set;
 
-    typedef Util::CExpMap<std::string, SServiceAttr> ConnectedMapT;
+    using ConnectedMapT = Util::CExpMap<std::string, SServiceAttr>;
     std::shared_timed_mutex     m_service_register_map_sync;
     ConnectedMapT               m_service_register_map;
   };

diff --git a/ecal/core/src/service/ecal_service_client_impl.cpp b/ecal/core/src/service/ecal_service_client_impl.cpp
@@ -320,7 +320,7 @@ namespace eCAL
                         };
 
             // Call service asynchronously
-            bool call_success = client->second->async_call_service(request_shared_ptr, response_callback);
+            const bool call_success = client->second->async_call_service(request_shared_ptr, response_callback);
 
             if (!call_success)
             {

diff --git a/ecal/core/src/service/ecal_service_server_impl.cpp b/ecal/core/src/service/ecal_service_server_impl.cpp
@@ -162,7 +162,7 @@ namespace eCAL
     m_service_id.clear();
 
     {
-      std::lock_guard<std::mutex> connected_lock(m_connected_mutex);
+      const std::lock_guard<std::mutex> connected_lock(m_connected_mutex);
       m_connected_v0 = false;
       m_connected_v1 = false;
     }
@@ -464,7 +464,7 @@ namespace eCAL
     bool mode_changed(false);
 
     {
-      std::lock_guard<std::mutex> connected_lock(m_connected_mutex);
+      const std::lock_guard<std::mutex> connected_lock(m_connected_mutex);
 
       // protocol version 0
       if (m_connected_v0)

diff --git a/ecal/core/src/service/ecal_service_singleton_manager.cpp b/ecal/core/src/service/ecal_service_singleton_manager.cpp
@@ -89,7 +89,7 @@ namespace eCAL
         return nullptr;
 
       // Lock the mutex to actually make it thread safe
-      std::lock_guard<std::mutex> singleton_lock(singleton_mutex);
+      const std::lock_guard<std::mutex> singleton_lock(singleton_mutex);
       if (!stopped)
       {
         // Create io_context, if it didn't exist, yet
@@ -126,7 +126,7 @@ namespace eCAL
         return nullptr;
 
       // Lock the mutex to actually make it thread safe
-      std::lock_guard<std::mutex> singleton_lock(singleton_mutex);
+      const std::lock_guard<std::mutex> singleton_lock(singleton_mutex);
       if (!stopped)
       {
         // Create io_context, if it didn't exist, yet
@@ -156,7 +156,7 @@ namespace eCAL
 
     void ServiceManager::stop()
     {
-      std::lock_guard<std::mutex> singleton_lock(singleton_mutex);
+      const std::lock_guard<std::mutex> singleton_lock(singleton_mutex);
 
       stopped = true;
 
@@ -177,7 +177,7 @@ namespace eCAL
 
     void ServiceManager::reset()
     {
-      std::lock_guard<std::mutex> singleton_lock(singleton_mutex);
+      const std::lock_guard<std::mutex> singleton_lock(singleton_mutex);
       stopped = false;
     }