Make ct happy again.

eclipse-ecal · Jan 20, 2025 · 4effd46 · 4effd46
1 parent 2fbbdf2
commit 4effd46
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/ecal/core/src/config/ecal_path_processing.cpp b/ecal/core/src/config/ecal_path_processing.cpp
@@ -231,9 +231,9 @@ namespace eCAL
       return {};
     }
 
-    bool DirManager::canWriteToDirectory(const std::string& dirPath) const 
+    bool DirManager::canWriteToDirectory(const std::string& path_) const 
     {
-      std::string testFilePath = dirPath + "/test_file.txt";
+      const std::string testFilePath = path_ + "/test_file.txt";
       std::ofstream testFile(testFilePath);
 
       if (testFile)
@@ -251,7 +251,7 @@ namespace eCAL
     // returns the directory path of the specified file
     std::string DirManager::getDirectoryPath(const std::string& file_path_) const
     {
-      size_t pos = file_path_.find_last_of("/\\");
+      const size_t pos = file_path_.find_last_of("/\\");
       return (std::string::npos == pos) ? "" : file_path_.substr(0, pos);
     }
 
@@ -339,7 +339,7 @@ namespace eCAL
   {
     std::string GeteCALLogDirImpl(const Util::IDirProvider& dir_provider_ /* = Util::DirProvider() */, const Util::IDirManager& dir_manager_ /* = Util::DirManager() */, const eCAL::Configuration& config_ /* = eCAL::GetConfiguration() */)
     {
-      std::string config_file_dir = dir_manager_.getDirectoryPath(eCAL::GetConfiguration().GetConfigurationFilePath());
+      const std::string config_file_dir = dir_manager_.getDirectoryPath(eCAL::GetConfiguration().GetConfigurationFilePath());
 
       const std::vector<std::string> log_paths = {
         dir_provider_.eCALEnvVar(ECAL_LOG_VAR),

diff --git a/ecal/core/src/config/ecal_path_processing.h b/ecal/core/src/config/ecal_path_processing.h
@@ -48,7 +48,7 @@ namespace eCAL
         virtual bool dirExistsOrCreate(const std::string& path_) const = 0;
         virtual bool createEcalDirStructure(const std::string& path_) const = 0;
         virtual bool canWriteToDirectory(const std::string& path_) const = 0;
-        virtual std::string getDirectoryPath(const std::string& filePath) const = 0;
+        virtual std::string getDirectoryPath(const std::string& file_path_) const = 0;
 
         virtual std::string findFileInPaths(const std::vector<std::string>& paths_, const std::string& file_name_) const = 0;
     };

diff --git a/ecal/core/src/logging/ecal_log_provider.cpp b/ecal/core/src/logging/ecal_log_provider.cpp
@@ -195,7 +195,7 @@ namespace eCAL
         log_path.pop_back();
 
       const std::string file_name = tstring + "_" + m_attributes.unit_name + "_" + std::to_string(m_attributes.process_id) + ".log";
-      std::vector<std::string> file_path_components = { log_path, file_name };
+      const std::vector<std::string> file_path_components = { log_path, file_name };
 
       m_logfile_name = EcalUtils::String::Join(std::string(1, EcalUtils::Filesystem::NativeSeparator()), file_path_components);
       m_logfile = fopen(m_logfile_name.c_str(), "w");