Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing presentationSubmission field + tests #161

Merged

Conversation

wolf4ood
Copy link
Contributor

WHAT

add missing presentationSubmission field + tests

Closes #159

@wolf4ood wolf4ood marked this pull request as ready for review January 15, 2025 11:25
@arnoweiss
Copy link
Contributor

Is there a functional necessity to add this? The issue sounds like the motivation is only that it's "required" by the DIF Presentation Exchange spec.

@wolf4ood
Copy link
Contributor Author

Yes it's actually required when using presentationDefinition in the PresentationQueryMessage. I forgot to change the text spec in this case

@arnoweiss
Copy link
Contributor

Thanks for adding to the spec text. I think this opens a larger question on the relationship between the DIF Presentation Exchange spec and the DCP - should something be required in DCP if it is required in DIF PE?

Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion among the committers Jan 16th, DCP reuses parts of the DIF Presentation Exchange selectively.

This PR expands that selection by adding metadata that helps the client parse the presentations. This is a convenience feature only provided by the option to query the CredentialService with a presentationDefinition yielding a presentationSubmission. Clients are freed of the requirement to introspect the presentation to obtain information like vc-data-model version, jwt/json-ld etc.

@wolf4ood wolf4ood merged commit 256d7df into eclipse-dataspace-dcp:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing presentationSubmission
2 participants