Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove context from credentialobject #124

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: remove context from credentialobject #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions artifacts/src/main/resources/issuance/example/credential-object.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
"fields": [
{
"path": [
"$.holderIdentifier"
"$.vc.type"
],
"filter": {
"type": "string",
"pattern": "^BPN[LS][a-zA-Z0-9]{12}$"
"pattern": "^AttestationCredential$"
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions artifacts/src/main/resources/issuance/example/credential-offer-message.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
"fields": [
{
"path": [
"$.holderIdentifier"
"$.vc.type"
],
"filter": {
"type": "string",
"pattern": "^BPN[LS][a-zA-Z0-9]{12}$"
"pattern": "^AttestationCredential$"
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions artifacts/src/main/resources/issuance/example/issuer-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
"fields": [
{
"path": [
"$.holderIdentifier"
"$.vc.type"
],
"filter": {
"type": "string",
"pattern": "^BPN[LS][a-zA-Z0-9]{12}$"
"pattern": "^AttestationCredential$"
}
}
]
Expand Down
37 changes: 21 additions & 16 deletions artifacts/src/test/java/org/eclipse/dcp/schema/issuance/CredentialObjectSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,21 +76,26 @@ public class CredentialObjectSchemaTest extends AbstractSchemaTest {
"JsonWebSignature2020"
],
"issuancePolicy": {
"permission": [
{
"action": "use",
"constraint": {
"and": [
{
"leftOperand": "CredentialPrereq",
"operator": "eq",
"rightOperand": "active"
}
]
}
}
]
}
"id": "Scalable trust example",
"input_descriptors": [
{
"id": "pd-id",
"constraints": {
"fields": [
{
"path": [
"$.vc.type"
],
"filter": {
"type": "string",
"pattern": "^AttestationCredential$"
}
}
]
}
}
]
}
}""";

@Test
Expand All @@ -105,7 +110,7 @@ void verifySchema() {
error("issuancePolicy", REQUIRED));

assertThat(schema.validate(INVALID_CREDENTIAL_REQUEST_MESSAGE_NO_TYPE_AND_CONTEXT, JSON))
.hasSize(6)
.hasSize(3)
.extracting(this::errorExtractor)
.contains(error("type", REQUIRED), error("@type", REQUIRED));

Expand Down
11 changes: 6 additions & 5 deletions specifications/credential.issuance.protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ No assumptions are made about the base URL, for example, if it is a domain, subd
The Credential Request API defines the REQUIRED [=Issuer Service=] endpoint for requesting [=Verifiable Credentials=].

The request MUST include an ID Token in the HTTP `Authorization` header prefixed with `Bearer` as defined in
the [[[#verifiable-presentation-access-token]]]. The `issuer` claim can be used by the [=Credential Service=] to resolve
the [[[#verifiable-presentation-access-token]]]. The `issuer` claim can be used by the [=Credential Service=] to resolve
the client's [=DID=] to obtain cryptographic material for validation and credential binding.

The ID Token MUST contain a `token` claim that is a bearer token granting write privileges for the
Expand Down Expand Up @@ -116,7 +116,8 @@ client's `Credential Service` using the Storage API defined in Section [[[#stora

## Storage API

The Storage API defines the REQUIRED [=Credential Service=] endpoint for writing issued credentials, typically invoked by
The Storage API defines the REQUIRED [=Credential Service=] endpoint for writing issued credentials, typically invoked
by
an [=Issuer Service=].

If a client is not authorized for an endpoint request, the [=Credential Service=] SHOULD return `4xx Client Error`. The
Expand Down Expand Up @@ -206,10 +207,10 @@ The following is a non-normative example of a credential offer request:
| | |
|--------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| **Schema** | [JSON Schema](./resources/v0.8/issuance/credential-object-schema.json) |
| **Required** | - `@context`: Specifies a valid Json-Ld context ([[json-ld11]], sect. 3.1). |
| | - `@type`: A string specifying the `CredentialObject` type |
| **Required** | - `@type`: A string specifying the `CredentialObject` type |
| | - `credentialType`: An array of strings defining the type of credential being offered |
| **Optional** | - `bindingMethods`: An array of strings defining the key material that an issued credential is bound to |
| **Optional** | - `@context`: Specifies a valid Json-Ld context ([[json-ld11]], sect. 3.1). As the `credentialObject` is usually embedded, its context is provided by the enveloping object. |
| | - `bindingMethods`: An array of strings defining the key material that an issued credential is bound to |
| | - `cryptography`: An array of strings defining the algorithm used for credential signing |
| | - `issuancePolicy`: A [presentation definition](https://identity.foundation/presentation-exchange/spec/v2.0.0/#presentation-definition) [[presentation-ex]] signifying the required [=Verifiable Presentation=] for issuance. |
| | - `offerReason`: A reason for the offer as a string. Valid values may include `reissue` and `proof-key-revocation` |
Expand Down
Loading