Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace odrl issuancePolicy with presentation definition #120

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

arnoweiss
Copy link
Contributor

WHAT

Having ODRL in the specification as signal what kind of credentials to present is an unnecessary indirection. Rather, this information can be conveyed to a Holder more efficiently by reusing the presentationDefinition object that is already used in the PresentationQueryMessage.

Closes #105

How was the issue fixed?

added reference to schemas, adjusted samples and tests.

More context

I was thinking if renaming the issuancePolicy to presentationDefinition in the CredentialObject would make sense for consistency's sake but would restrict extensibility, so I'd suggest to leave it as proposed in this PR.

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit to use camel case, otherwise looks good to me.

@jimmarino jimmarino self-requested a review December 10, 2024 07:44
@arnoweiss arnoweiss requested a review from fredg02 December 10, 2024 11:27
@fredg02
Copy link

fredg02 commented Dec 10, 2024

@arnoweiss I assume you requested a review from me accidentally?

@arnoweiss
Copy link
Contributor Author

yea sorry

@arnoweiss I assume you requested a review from me accidentally?

@fredg02
Copy link

fredg02 commented Dec 10, 2024

No worries.

@arnoweiss arnoweiss merged commit e806b51 into eclipse-dataspace-dcp:main Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clarification on issuancePolicy
3 participants