Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace cryptographicSuites with cryptography #111

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

paullatzelsperger
Copy link
Contributor

WHAT

changes the wording from cryptographicSuites to cryptography to be more generic

Closes #94

How was the issue fixed?

JsonWebKey2020 is not a cryptographic suite, it is a way to publicize key material. The term "cryptographic suite" is based on a discontinued draft spec, so we opted for the more generic "cryptography

More context

List other areas that have changed but are not necessarily linked to the main feature. This could be naming changes,
bugs that were encountered and were fixed inline, etc.

@paullatzelsperger paullatzelsperger added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 25, 2024
@paullatzelsperger paullatzelsperger force-pushed the docs/wording_cryptographicSuites branch from 8d5d1ae to 3803269 Compare November 25, 2024 08:59
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, let's see other's opinions.

@jimmarino
Copy link
Contributor

/cc @arnoweiss

Copy link
Contributor

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering the review

@jimmarino jimmarino merged commit 91e2f7b into main Nov 25, 2024
3 checks passed
@paullatzelsperger paullatzelsperger deleted the docs/wording_cryptographicSuites branch November 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonWebKey2020 is not really a cryptographic suite but a container for holding (public) key material..
4 participants