-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: replace cryptographicSuites with cryptography #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Nov 25, 2024
paullatzelsperger
force-pushed
the
docs/wording_cryptographicSuites
branch
from
November 25, 2024 08:59
8d5d1ae
to
3803269
Compare
jimmarino
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this, let's see other's opinions.
/cc @arnoweiss |
arnoweiss
reviewed
Nov 25, 2024
artifacts/src/main/resources/issuance/example/issuer-metadata.json
Outdated
Show resolved
Hide resolved
artifacts/src/main/resources/issuance/example/credential-offer-message.json
Outdated
Show resolved
Hide resolved
…json Co-authored-by: Arno Weiß <[email protected]>
…-message.json Co-authored-by: Arno Weiß <[email protected]>
Co-authored-by: Arno Weiß <[email protected]>
arnoweiss
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for considering the review
mkollenstart
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
changes the wording from
cryptographicSuites
tocryptography
to be more genericCloses #94
How was the issue fixed?
JsonWebKey2020 is not a cryptographic suite, it is a way to publicize key material. The term "cryptographic suite" is based on a discontinued draft spec, so we opted for the more generic
"cryptography
More context
List other areas that have changed but are not necessarily linked to the main feature. This could be naming changes,
bugs that were encountered and were fixed inline, etc.