Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detector type icons in editor tabs #2022

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Mailaender
Copy link
Contributor

@Mailaender Mailaender commented Jan 14, 2025

to get some vertical space back since the column type is also suffixed now:
grafik
and regain some consistency with the 3.X editor from projects that does not add these suffixes.

@eselmeister
Copy link
Contributor

Adding distinct icons for different detector types is a good idea. But to display the detector type [CSD], [MSD], [VSD], [WSD] helps to keep the overview if a chromatogram with the same name but different detectors is open in the editor tab. Hence, I would like to keep it.

@Mailaender Mailaender changed the title Replace detector type suffix with icon in editor tabs Add detector type icons in editor tabs Jan 17, 2025
@eselmeister eselmeister merged commit c8eb973 into eclipse-chemclipse:develop Jan 17, 2025
3 checks passed
@Mailaender Mailaender deleted the editor-tab-icons branch January 17, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants