fix: delete workspace flow

[olexii4]

What does this PR do?

Fix delete workspace flow.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fix eclipse-che/che#23337

Is it tested? How?

Release Notes

Docs PR

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[che-bot]

Click here to review and test in web IDE:

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1318

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1318", name: che-dashboard}]}}]"

[codecov]

Codecov Report

Attention: Patch coverage is 48.90511% with 70 lines in your changes missing coverage. Please review.

Project coverage is 91.75%. Comparing base (13063fb) to head (bacacbb).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
.../contexts/WorkspaceActions/DeleteWarning/index.tsx	38.77%	60 Missing ⚠️
...rontend/src/contexts/WorkspaceActions/Provider.tsx	72.22%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
- Coverage   91.91%   91.75%   -0.17%     
==========================================
  Files         501      502       +1     
  Lines       45503    45603     +100     
  Branches     3194     3191       -3     
==========================================
+ Hits        41825    41843      +18     
- Misses       3643     3725      +82     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ibuziuk]

Changing storage type before removing workspace is not a good option since PVC will not be deleted / cleaned after that.

Given that this is a regression we need to:

• detect the commit that resulted in this behaviour
• review the changes and identify if there is another option to fix the problem

@dmytro-ndp @artaleks9 folks, maybe you have more details on which upstream version the problem started to happen

Also, marking eclipse-che/che#23337 as a blocker

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1318

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1318", name: che-dashboard}]}}]"

[github-actions]

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1318

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1318", name: che-dashboard}]}}]"