Fix Change of verbiage to helper text under the 'Import from Git' text box. #1311
Conversation
|
Click here to review and test in web IDE: |
|
Hi @tyraziel. Thanks for your PR. I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
packages/dashboard-frontend/src/components/ImportFromGit/index.tsx
Outdated
Show resolved
Hide resolved
| @@ -180,7 +180,7 @@ class ImportFromGit extends React.PureComponent<Props, State> { | |||
| validated={validated} | |||
| helperTextInvalid={errorMessage} | |||
| helperTextInvalidIcon={<ExclamationCircleIcon />} | |||
| helperText="Import from a Git repository to create your first workspace." | |||
| helperText="Import a devfile from a Git repository to create a new workspace or launch an existing one." | |||
There was a problem hiding this comment.
| helperText="Import a devfile from a Git repository to create a new workspace or launch an existing one." | |
| helperText="Import from a Git repository to create a Cloud Development Environment" |
There was a problem hiding this comment.
I think my main hangup is that if an environment of the same name already exists, it will ask if you want to open the existing one or create a new one. Trying to capture that concisely is the tricky part.
What if we changed it from "create" to "launch"? Does launch indicate create/open?
"Import from a Git repository to launch a Cloud Development Environment"
There was a problem hiding this comment.
@tyraziel "launch" sounds good 👍
There was a problem hiding this comment.
Committed update @ibuziuk - ok to resolve conversation?
|
@tyraziel thank you for the first contribution \o/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
+ Coverage 91.68% 91.83% +0.14%
==========================================
Files 500 501 +1
Lines 45482 45535 +53
Branches 3164 3182 +18
==========================================
+ Hits 41700 41816 +116
+ Misses 3754 3687 -67
- Partials 28 32 +4 ☔ View full report in Codecov by Sentry. |
I should be all set with this. |
|
/retest |
.../dashboard-frontend/src/components/ImportFromGit/__tests__/__snapshots__/index.spec.tsx.snap
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, olexii4, tyraziel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tyraziel Thank you for your contribution. Could you please create one commit with these changes? Note: Your git-commit should be signed. You can do it with a command: |
Signed-off-by: tyraziel <[email protected]>
tyraziel
force-pushed
the
import-from-git-verbaige-change
branch
from
ca99793 to
e2caaa6
Compare
|
New changes are detected. LGTM label has been removed. |
|
@olexii4 please, clarify why the PR checks are failing? |
|
Build 3.20 :: dashboard_3.x/629: Console, Changes, Git Data |
|
Build 3.20 :: sync-to-downstream_3.x/8796: Console, Changes, Git Data |
|
Build 3.20 :: push-latest-container-to-quay_3.x/5089: Console, Changes, Git Data |
|
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8914: dashboard : 3.x :: Build 66725740 : quay.io/devspaces/dashboard-rhel9:3.20-2 |
|
Build 3.20 :: update-digests_3.x/8613: Console, Changes, Git Data |
|
Build 3.20 :: dashboard_3.x/629: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8796 triggered |
|
Build 3.20 :: operator-bundle_3.x/4470: Console, Changes, Git Data |
|
Build 3.20 :: sync-to-downstream_3.x/8799: Console, Changes, Git Data |
|
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8917: devspaces-operator-bundle : 3.x :: Failed in 66726408 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
This PR changes the verbiage of the helper text under the Import from Git text box.
What issues does this PR fix or reference?
If you have more than zero workspaces, the verbiage doesn't make sense.
Is it tested? How?
I ran the tests from the devfile command.
Release Notes
Verbiage update on Create Workspace page.
Docs PR
N/A