-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not skip SSH urls from resolving devfile (#1252) #1255
Conversation
Revert the condition that does not allow to resolve devfile for SSH factory urls.
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1255 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1255", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmytro-ndp, ibuziuk, olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.17 :: dashboard_3.17/19: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/91: Console, Changes, Git Data |
Build 3.17 :: get-sources-rhpkg-container-build_3.17/96: dashboard : 3.17 :: Failed in 65893973 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.17 :: dashboard_3.17/20: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/92: Console, Changes, Git Data |
Build 3.17 :: get-sources-rhpkg-container-build_3.17/97: dashboard : 3.17 :: Failed in 65897677 : BREW:BUILD/STATUS:UNKNOWN |
Build 3.17 :: dashboard_3.17/21: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.17/94: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.17/82: Console, Changes, Git Data |
Build 3.17 :: get-sources-rhpkg-container-build_3.17/99: dashboard : 3.17 :: Build 65900008 : quay.io/devspaces/dashboard-rhel8:3.17-24 |
Build 3.17 :: dashboard_3.17/21: Upstream sync done; /DS_CI/sync-to-downstream_3.17/94 triggered |
Revert the condition that does not allow to resolve devfile for SSH factory urls.
What does this PR do?
Cherry pick from #1252
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Is it tested? How?
Release Notes
Docs PR