-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an ability to show provider info into samples #1236
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
+ Coverage 89.82% 90.03% +0.21%
==========================================
Files 445 445
Lines 46024 46042 +18
Branches 3104 3114 +10
==========================================
+ Hits 41342 41456 +114
+ Misses 4647 4548 -99
- Partials 35 38 +3 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1236 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1236", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1236 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1236", name: che-dashboard}]}}]" |
@azatsarynnyy please, review. I believe we also need to update the editors with the new attribute - https://github.com/eclipse-che/che-operator/tree/main/editors-definitions |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1236 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1236", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @olexii4 for a quick patch! 👍
Updated editor tile UI looks awesome ❤️
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, azatsarynnyy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Oleksii Orel <[email protected]>
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1236 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1236", name: che-dashboard}]}}]" |
Build 3.18 :: dashboard_3.x/578: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7889: Console, Changes, Git Data |
What does this PR do?
Add an ability to show provider info into samples.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23204
needed for https://issues.redhat.com/browse/CRW-7547
Is it tested? How?
metadata.attributes.provider = 'Provided by [Jet Brains](https://www.jetbrains.com/) under [License](https://www.jetbrains.com/legal/docs/toolbox/user/)'
Release Notes
Docs PR