Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an ability to show provider info into samples #1236

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 23, 2024

What does this PR do?

Add an ability to show provider info into samples.

Screenshot/screencast of this PR

Знімок екрана 2024-10-23 о 04 55 25

What issues does this PR fix or reference?

fixes eclipse-che/che#23204
needed for https://issues.redhat.com/browse/CRW-7547

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Patch editor with metadata.attributes.provider = 'Provided by [Jet Brains](https://www.jetbrains.com/) under [License](https://www.jetbrains.com/legal/docs/toolbox/user/)'
  3. Open Create Workspace page on the dashboard.
  4. Open Editor Selector/Choose an Editor
  5. Jet Brains PyCharm editor should have a provider info.
    Знімок екрана 2024-10-23 о 09 39 26
schemaVersion: 2.2.2
metadata:
  name: che-pycharm-server
  displayName: Jet Brains PyCharm Professional Edition (desktop)
  description: JetBrains PyCharm Professional Edition for Eclipse Che - latest
  tags:
    - Tech-Preview
  attributes:
    publisher: che-incubator
    version: latest
    provider: Provided by [Jet Brains](https://www.jetbrains.com/) under [License](https://www.jetbrains.com/legal/docs/toolbox/user/)
    title: JetBrains PyCharm Professional Edition for Eclipse Che - latest
    repository: https://github.com/che-incubator/che-idea-dev-server
    firstPublicationDate: '2024-18-09'
    iconMediatype: image/svg+xml
    ...

Release Notes

Docs PR

Copy link

openshift-ci bot commented Oct 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Oct 23, 2024

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.03%. Comparing base (5252f8c) to head (c4bb779).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/dashboard-backend/src/constants/examples.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1236      +/-   ##
==========================================
+ Coverage   89.82%   90.03%   +0.21%     
==========================================
  Files         445      445              
  Lines       46024    46042      +18     
  Branches     3104     3114      +10     
==========================================
+ Hits        41342    41456     +114     
+ Misses       4647     4548      -99     
- Partials       35       38       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1236

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1236", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1236

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1236", name: che-dashboard}]}}]"

@olexii4 olexii4 marked this pull request as ready for review October 23, 2024 06:44
@ibuziuk
Copy link
Member

ibuziuk commented Oct 23, 2024

@azatsarynnyy please, review. I believe we also need to update the editors with the new attribute - https://github.com/eclipse-che/che-operator/tree/main/editors-definitions

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1236

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1236", name: che-dashboard}]}}]"

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @olexii4 for a quick patch! 👍
Updated editor tile UI looks awesome ❤️

Copy link

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, azatsarynnyy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 23, 2024

New changes are detected. LGTM label has been removed.

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1236

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1236", name: che-dashboard}]}}]"

@olexii4 olexii4 merged commit 3efe8ae into main Oct 23, 2024
19 of 20 checks passed
@olexii4 olexii4 deleted the samples branch October 23, 2024 14:46
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/578: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow links rendering for the metadata.displayName of the editor definitions
6 participants