Restrict Pin View and Open View to active CPP debug context. #1049
+372
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how fix looks like. |
|
FYI, @iloveeclipse , @jonahgraham |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
jonahgraham
reviewed
Jan 21, 2025
...g.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/OpenNewViewHandler.java
Outdated
Show resolved
Hide resolved
raghucssit
force-pushed
the
migrate_pin_view_action
branch
2 times, most recently
from
8e73224 to
9a457cb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jonahgraham
requested changes
Jan 22, 2025
...g/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/PinViewHandler.java
Outdated
Show resolved
Hide resolved
...g/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/PinViewHandler.java
Outdated
Show resolved
Hide resolved
...e.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/PinCommandEnablementTester.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
jonahgraham
reviewed
Jan 23, 2025
...e.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/PinCommandEnablementTester.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
jonahgraham
requested changes
Jan 23, 2025
...e.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/PinCommandEnablementTester.java
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
raghucssit
force-pushed
the
migrate_pin_view_action
branch
2 times, most recently
from
a886ecf to
c4bbb43
Compare
|
@jonahgraham I have fixed all the comments and tested. It works fine. Thanks for all the suggestions and guidelines. |
Yes, I'll keep an eye on it and kick it off when services are back from their maintenance downtime https://www.eclipsestatus.io/ |
jonahgraham
reviewed
Jan 26, 2025
...i/src/org/eclipse/cdt/dsf/debug/internal/ui/debugview/layout/PinCommandEnablementTester.java
Outdated
Show resolved
Hide resolved
...i/src/org/eclipse/cdt/dsf/debug/internal/ui/debugview/layout/PinCommandEnablementTester.java
Outdated
Show resolved
Hide resolved
raghucssit
force-pushed
the
migrate_pin_view_action
branch
from
c4bbb43 to
1c08368
Compare
raghucssit
force-pushed
the
migrate_pin_view_action
branch
from
1c08368 to
7e3c76f
Compare
That is if any CPP application is under debug. Because Pin View is never enabled other than CPP application debug session. This also includes Action to Command migration. Fixes eclipse-cdt#1048
jonahgraham
force-pushed
the
migrate_pin_view_action
branch
from
7e3c76f to
9689b69
Compare
jonahgraham
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Thanks @raghucssit
I have rebased this change, updated the commit comment to say "Fixes" to automatically close #1048 when we merge and applied the final trivial fix review comment I just created.
Once build passes this will be merged.
...g/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/actions/PinViewHandler.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is if any CPP application is under debug. Because Pin View is never enabled other than CPP application debug session.
This also includes Action to Command migration.
Fixes #1048