Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary space after comment #1034

Merged

Conversation

ernstblechaPT
Copy link

For some reason the comment-XML attribute had a stray whitespace after the attribute. Based on the examples I had available removing this whitespace should pose no problems.

@ernstblechaPT ernstblechaPT changed the base branch from release to develop February 10, 2025 12:31
@ernstblechaPT ernstblechaPT requested a review from azoitl February 10, 2025 12:32
Copy link

github-actions bot commented Feb 10, 2025

Test Results

   113 files  ±0     113 suites  ±0   49s ⏱️ +2s
29 183 tests ±0  29 183 ✅ ±0  0 💤 ±0  0 ❌ ±0 
29 184 runs  ±0  29 184 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 30e4010. ± Comparison against base commit dfb92ce.

♻️ This comment has been updated with latest results.

@ernstblechaPT ernstblechaPT force-pushed the unnecessary_space_after_comment branch from ae99b1a to 30e4010 Compare February 10, 2025 14:18
@ernstblechaPT
Copy link
Author

To clear up why I made this change: For VarDeclarations if a comment is added and a InitialValue the space in between those attributes gets doubled up:

image

@azoitl azoitl merged commit 4f8372f into eclipse-4diac:develop Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants