Updating displayName Reactive #2994 #3403
Conversation
|
So cool. Thank you for your contribution. I'll review it tomorrow 😊 |
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
frontend/src/views/Profile.vue
Outdated
| methods: { | ||
| reloadUser() { | ||
| this.api.reload(this.user).then((user) => { | ||
| this.$store.commit('login', user) |
There was a problem hiding this comment.
To make this more easily understandable, could you add another mutation called "updateUser" to
frontend/src/components/store/auth.js, and then use that here?
The mutation code (single line) will be duplicated, but what we're doing here isn't really a re-login, but an update of the user state. Maybe these two actions will have different behaviour in the future.
|
I also noticed the update is not applied if I navigate away from the profile edit during the save operation (I was testing on my phone). Not sure how to solve this though... |
|
Maybe it was also a bad idea of us in the first place, to store a duplicated user state in the auth store. Maybe we would be better off storing only the user URI (which we get from the JWT from the API) there, and reading the user data from the normal API store when needed. But this |
|
@DeNic0la: Very cool - thx! |
PR for issue #2994
Reload user entity after changing
firstname,surnameornickname