-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[paper] finalize #405
base: main
Are you sure you want to change the base?
[paper] finalize #405
Conversation
We'll also need to list potential reviewers, any suggestions? |
mmh good question, markdown looks nicer but the former gives a more "accurate" representation of what people will get |
wasn't there a reviewer list on JOSS, or have they dismissed it? |
Maybe let's keep text tables |
Agreed. Regarding your comment about generalization of results (TODO: is this correct?): basically, G-computation, like propensity scores, attempts at conducting a "pseudo-randomization" for observational data, where randomization is not possible. This is why we have a "hypothetical", broader population that is not equal to the sample. It should reduce confounder bias between groups (levels of focal predictors), which means, it's more "representative" of a population, i.e. more generalizable. |
@mattansb @bwiernik @IndrajeetPatil @rempsyc You're listed as co-authors, would you approve the paper or would you like to revise anything? |
one rule: do not talk about the marginalization option names here 😁 |
Dom thinking: just approve your affiliation, that's enough... |
LGTM |
Should we add a paragraph about |
I'll give it a read when I'm flying home Saturday |
No strong opinion here, but I think the paper is already quite long for a JOSS paper. I would probably put more effort into another paper that could be submitted to a (listed) journal. |
Mmh fair fair I'll see if I can throw in 2 sentences about that for the sake of comprehensiveness but we can keep our efforts for another paper |
Sorry Dom, but I think we should nail down the marginalization names before submitting. Which issue has the discussion on that again? |
Here |
No description provided.