use openxlsx2::wb_colour() to construct cormatrix_to_excel colours

[JanMarvin]

(required as of openxlsx2 1.13)

Hi, I ran a revdepcheck and the following came up. Starting with openxlsx2 1.13 we do no longer allow construction of colours as c(rgb = ...) and instead require our wb_colour() helper. Basically as a safeguard because this applies an attributes we can check against.

Could you please review this PR and create a CRAN release within the next two weeks. I was about to do a CRAN release today, but that's stalled now (shame on me, the change was incorporated a while ago).

Thanks!

[bwiernik]

Thanks! Will run checks and submit this soon

[rempsyc]

Thanks Brenton

[JanMarvin]

Hi, do you know if you can make a CRAN release this week? I'd like to avoid causing havoc and if not, I'd have to figure out another way to avoid the revdep throwing ERRORs

[bwiernik]

Sorry this slipped off my radar. Will do tomorrow

[JanMarvin]

Thank you!

[JanMarvin]

Hey everyone, just a quick update. I've submitted openxlsx2 version 1.13 to CRAN. As far as I know, the CRAN submission check only verifies packages in Reverse imports, not those in Reverse suggests. So, if the submission is approved, you may receive a CRAN request to fix the broken test in the coming days.

Apologies for being the bearer of bad news, but this should have given you at least two more weeks for a submission. Which to my understanding is just a formality.

[JanMarvin]

Well, CRAN checks for suggests as well. I have written them that the failures are expected and that I would want to proceed with the submission.