-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2 - development -> main #47
Conversation
…exon data passed out in array and directly rendered with datatables & plotly in html
1.2 - add dataTables functionality to variant tables from VCFs
Hello @jethror1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-07-07 15:45:39 UTC |
1.2 - fix rounding for sub-threshold table
1.2 - Update readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 10 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jethror1)
Changes to functionality to improve usability and reduce file sizes. Adds a scrollable window, searching and deferred rendering to all tables and plots, allowing for large panels to not increase file size greatly and still load in similar time to smaller panels.
Component PRs included:
Issues fixed:
Full combined PR notes here
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)