Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2 - development -> main #47

Merged
merged 121 commits into from
Jul 7, 2021
Merged

1.2 - development -> main #47

merged 121 commits into from
Jul 7, 2021

Conversation

jethror1
Copy link
Collaborator

@jethror1 jethror1 commented Jul 5, 2021

Changes to functionality to improve usability and reduce file sizes. Adds a scrollable window, searching and deferred rendering to all tables and plots, allowing for large panels to not increase file size greatly and still load in similar time to smaller panels.

Component PRs included:

Issues fixed:

Full combined PR notes here


This change is Reviewable

@jethror1 jethror1 requested a review from mattgarner July 5, 2021 16:07
@pep8speaks
Copy link

pep8speaks commented Jul 5, 2021

Hello @jethror1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 60:80: E501 line too long (80 > 79 characters)
Line 82:5: E303 too many blank lines (2)
Line 115:80: E501 line too long (83 > 79 characters)

Line 247:80: E501 line too long (80 > 79 characters)
Line 1084:80: E501 line too long (88 > 79 characters)
Line 1403:80: E501 line too long (82 > 79 characters)
Line 1410:80: E501 line too long (81 > 79 characters)

Line 283:80: E501 line too long (80 > 79 characters)

Line 43:5: E303 too many blank lines (2)
Line 64:5: E303 too many blank lines (2)
Line 85:5: E303 too many blank lines (2)
Line 366:80: E501 line too long (80 > 79 characters)

Comment last updated at 2021-07-07 15:45:39 UTC

@jethror1 jethror1 changed the title Development 1.2 - development -> main Jul 5, 2021
@jethror1 jethror1 added bug Something isn't working enhancement New feature or request labels Jul 6, 2021
Copy link
Contributor

@mattgarner mattgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work

Copy link
Contributor

@mattgarner mattgarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 10 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jethror1)

@mattgarner mattgarner merged commit 755255b into master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment