Storage: add object_store backend #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
object_store
branch
3 times, most recently
from
996d232 to
ef51b3a
Compare
dcherian
commented
Aug 15, 2024
dcherian
commented
Aug 15, 2024
dcherian
commented
Aug 15, 2024
dcherian
commented
Aug 15, 2024
paraseba
reviewed
Aug 15, 2024
src/storage.rs
Outdated
| .store | ||
| .head(path) | ||
| .await | ||
| .map_err(|err| StorageError::ParquetReadError(Box::new(err)))?; |
There was a problem hiding this comment.
so weird ... we won't be able to afford two roundtrips to s3. Why does it want this?
dcherian
commented
Aug 15, 2024
dcherian
commented
Aug 15, 2024
dcherian
commented
Aug 15, 2024
1. Test parquet read/write for all ObjectStorage types 2. Test datasets only with ObjectStorage::InMemoryStore
dcherian
commented
Aug 16, 2024
| } | ||
|
|
||
| #[tokio::test(flavor = "multi_thread")] | ||
| async fn test_read_write_parquet_object_storage() { |
* main: Arc<Bytes> -> Bytes (#16)
* main: Fix a bug with adding chunks to existing arrays
dcherian
commented
Aug 16, 2024
Comment on lines
+202
to
+206
| let upload = self.store.put_multipart(&path).await?; | ||
| // TODO: new_with_chunk_size? | ||
| let mut write = object_store::WriteMultipart::new(upload); | ||
| write.write(&bytes); | ||
| write.finish().await?; |
There was a problem hiding this comment.
Went with https://docs.rs/object_store/latest/object_store/struct.WriteMultipart.html instead of https://docs.rs/object_store/latest/object_store/trait.MultipartUpload.html because it seemed easier.
dcherian
commented
Aug 16, 2024
paraseba
approved these changes
Aug 16, 2024
dcherian
force-pushed
the
object_store
branch
3 times, most recently
from
dc1ae54 to
398e481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.