Fix bug in clean prefix detection (#761)

earth-mover · Feb 20, 2025 · 8dfd099 · 8dfd099
1 parent 880f37d
commit 8dfd099
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 30 deletions.
diff --git a/icechunk/src/storage/logging.rs b/icechunk/src/storage/logging.rs
@@ -209,10 +209,6 @@ impl Storage for LoggingStorage {
         self.backend.get_snapshot_last_modified(settings, snapshot).await
     }
 
-    async fn root_is_clean(&self) -> StorageResult<bool> {
-        self.backend.root_is_clean().await
-    }
-
     async fn get_object_range_buf(
         &self,
         key: &str,

diff --git a/icechunk/src/storage/mod.rs b/icechunk/src/storage/mod.rs
@@ -363,7 +363,9 @@ pub trait Storage: fmt::Debug + private::Sealed + Sync + Send {
         snapshot: &SnapshotId,
     ) -> StorageResult<DateTime<Utc>>;
 
-    async fn root_is_clean(&self) -> StorageResult<bool>;
+    async fn root_is_clean(&self) -> StorageResult<bool> {
+        Ok(self.list_objects(&Settings::default(), "").await?.next().await.is_none())
+    }
 
     async fn list_chunks(
         &self,

diff --git a/icechunk/src/storage/object_store.rs b/icechunk/src/storage/object_store.rs
@@ -583,17 +583,6 @@ impl Storage for ObjectStorage {
         Ok(res.last_modified)
     }
 
-    #[instrument(skip(self))]
-    async fn root_is_clean(&self) -> StorageResult<bool> {
-        Ok(self
-            .get_client()
-            .await
-            .list(Some(&ObjectPath::from(self.backend.prefix())))
-            .next()
-            .await
-            .is_none())
-    }
-
     #[instrument(skip(self))]
     async fn get_object_range_buf(
         &self,

diff --git a/icechunk/src/storage/s3.rs b/icechunk/src/storage/s3.rs
@@ -639,20 +639,6 @@ impl Storage for S3Storage {
         Ok(res)
     }
 
-    #[instrument(skip(self))]
-    async fn root_is_clean(&self) -> StorageResult<bool> {
-        let res = self
-            .get_client()
-            .await
-            .list_objects_v2()
-            .bucket(self.bucket.clone())
-            .prefix(self.prefix.clone())
-            .max_keys(1)
-            .send()
-            .await?;
-        Ok(res.contents.map(|v| v.is_empty()).unwrap_or(true))
-    }
-
     #[instrument(skip(self))]
     async fn get_object_range_buf(
         &self,