Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumb): use right arguments #2056

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix(breadcrumb): use right arguments #2056

merged 1 commit into from
Jan 12, 2024

Conversation

PrashantAshok
Copy link
Contributor

@PrashantAshok PrashantAshok commented Jan 11, 2024

Description

Fixes the arguments being emitted. This also brings in the fix made here #2015

Reproducible here https://opensource.ebay.com/ebayui-core/?path=/docs/navigation-disclosure-ebay-breadcrumbs--documentation

Context

References

Screenshots

Screen Shot 2024-01-11 at 2 46 50 PM

@PrashantAshok PrashantAshok self-assigned this Jan 11, 2024
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@agliga agliga merged commit f98a24c into master Jan 12, 2024
1 check passed
@agliga agliga deleted the fix-breadcrumb branch January 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants