Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-textbox): pass 'range' to calendar #2052

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix(date-textbox): pass 'range' to calendar #2052

merged 1 commit into from
Jan 11, 2024

Conversation

HenriqueLimas
Copy link
Member

Description

  • Pass range also to ebay-calendar to proper render the range

Context

...calendarInput doesn't have range included since it is used also on date-textbox, so it needs to be passed down

Screenshots

Before:

Screen Shot 2024-01-09 at 5 39 17 PM

After:
Screen Shot 2024-01-09 at 5 39 36 PM

@HenriqueLimas HenriqueLimas self-assigned this Jan 10, 2024
LuLaValva
LuLaValva approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HenriqueLimas, good catch.

@LuLaValva LuLaValva merged commit b863dfa into master Jan 11, 2024
1 check passed
@LuLaValva LuLaValva deleted the fix-date-textbox-range branch January 11, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agliga agliga agliga approved these changes

@LuLaValva LuLaValva LuLaValva approved these changes

Assignees

@HenriqueLimas HenriqueLimas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenriqueLimas @agliga @LuLaValva