feat(date-textbox): allow clear by setting value to null #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtBlue
reviewed
Jan 5, 2024
| @@ -66,7 +66,7 @@ class DateTextbox extends Marko.Component<Input, State> { | |||
| } | |||
|
|
|||
| onInput(input: Input) { | |||
| if (input.value) { | |||
| if (input.value !== undefined) { | |||
There was a problem hiding this comment.
Do we need to account for empty strings in this conditional?
There was a problem hiding this comment.
No, we shouldn't need to. An empty string would also work to clear the date textbox, but devs shouldn't be passing any strings that don't work as ISO strings.
ArtBlue
approved these changes
Jan 5, 2024
|
This is a feature and should be targeting |
agliga
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
valuetonullScreenshots