Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storybook): add missing 'skin/utility' and fix type imports #2047

Merged
merged 2 commits into from
Jan 4, 2024
Merged

chore(storybook): add missing 'skin/utility' and fix type imports #2047

merged 2 commits into from
Jan 4, 2024

Conversation

HenriqueLimas
Copy link
Member

Description

  • Add skin/utility class on storybook
  • Add import type to global.ts imports

Context

Without skin/utility the clipped class is not styled properly.
WIthout import type, the following error is show on storybook locally:

image

Screenshots

Without skin/utility

image

With skin/utility

Screen Shot 2024-01-04 at 11 06 46 AM

@HenriqueLimas HenriqueLimas self-assigned this Jan 4, 2024
agliga
agliga reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two comments (one nit and another question)

.storybook/preview.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@agliga agliga merged commit 2eca2b5 into master Jan 4, 2024
1 check passed
@agliga agliga deleted the fix/storybook-style branch January 4, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agliga agliga agliga approved these changes

@LuLaValva LuLaValva LuLaValva approved these changes

Assignees

@HenriqueLimas HenriqueLimas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HenriqueLimas @agliga @LuLaValva