Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process time out returns incorrect exception in pythonsdk e2b 1476 #550

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Process time out returns incorrect exception in pythonsdk e2b 1476 #550

wants to merge 4 commits into from

Conversation

jakubno
Copy link
Member

@jakubno jakubno commented Jan 24, 2025

Handle the exception properly

@jakubno jakubno requested a review from ValentaTomas as a code owner January 24, 2025 05:18
@linear Linear
Copy link

linear bot commented Jan 24, 2025

E2B-1476 Process time out returns incorrect exception in PythonSDK

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae61d83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jakubno jakubno self-assigned this Jan 24, 2025
@jakubno jakubno added the bug Something isn't working label Jan 24, 2025
@ValentaTomas
Copy link
Member

I think the exception handling is also missing in the async python implementation.

ValentaTomas
ValentaTomas reviewed Jan 24, 2025
View reviewed changes
packages/python-sdk/e2b/sandbox_sync/commands/command_handle.py
exit_code=event.event.end.exit_code,
error=event.event.end.error,
)
except Exception as e:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure the incorrect exception originated from here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentaTomas ValentaTomas ValentaTomas left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@jakubno jakubno

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubno @ValentaTomas