Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default generated code for e2b.Dockerfile when initializing custom template #547

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mlejva
Copy link
Member

@mlejva mlejva commented Jan 20, 2025

Everywhere in docs, we direct users to be using our code interpreter package. However when you run e2b template init, we still generate the e2b.Dockerfile with

FROM ubuntu:22.04

which won't work with the code interpreter package.

This PR changes the generated code to

FROM e2bdev/code-interpreter:latest

Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 71e8b3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@e2b/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mlejva mlejva changed the title Change the default e2b.Dockerfile code when running Change the default generated code for e2b.Dockerfile when initializing custom template Jan 21, 2025
Copy link
Member

@jakubno jakubno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't work, because of missing start_cmd

@mlejva
Copy link
Member Author

mlejva commented Jan 21, 2025

This still won't work, because of missing start_cmd

Can you expand? This should work because users run e2b template build -c "/root/.jupyter/start-up.sh".

A user just had this issue that they generated e2b.Dockerfile with e2b template init and then they ran -c "/root/.jupyter/start-up.sh".

Copy link
Member

jakubno commented Jan 21, 2025

I see, in that case it's okay

@jakubno
Copy link
Member

jakubno commented Jan 21, 2025

I am thinking if we shouldn't do something in CLI, if it's only this Dockerfile and start command wasn't passed, add it automatically?

@ValentaTomas ValentaTomas added the Improvement Improvement for current functionality label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Improvement for current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants