Skip to content

Commit

Permalink
remove unnecessary dir attributes from contribution and project cards
Browse files Browse the repository at this point in the history
  • Loading branch information
ZibanPirate committed Jan 1, 2025
1 parent 3f1ffdb commit 9e9d6a4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion web/src/components/contribution-card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export function ContributionCard({
return (
<Link
className="card card-compact bg-base-300 flex-auto w-full max-w-xs sm:max-w-sm"
dir="ltr"
href={getContributionURL(contribution)}
// TODO-OB: there's a bug here: when passing onClick to Link, the link no longer work as a SPA link, and instead causes a full reload of the page
onClick={onClick}
Expand Down
1 change: 0 additions & 1 deletion web/src/components/project-card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export function ProjectCard({
return (
<Link
href={getProjectURL(project)}
dir="ltr"
className="bg-base-300 w-full max-w-xs sm:max-w-sm flex flex-col rounded-lg border-base-200 border-2 overflow-hidden"
// TODO-OB: there's a bug here: when passing onClick to Link, the link no longer work as a SPA link, and instead causes a full reload of the page
onClick={onClick}
Expand Down
5 changes: 1 addition & 4 deletions web/src/pages/contribute/contribution/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,7 @@ export default function Page(): JSX.Element {
) : (
<div className="flex flex-col gap-4 items-center p-4">
{/* TODO-ZM: more tailored design for /contribute/:slug page instead of copy-pasting components from /contribute */}
<div
dir="ltr"
className="card card-compact bg-base-300 flex-auto w-full max-w-xs sm:max-w-sm"
>
<div className="card card-compact bg-base-300 flex-auto w-full max-w-xs sm:max-w-sm">
<div className="card-body markdown">
<div className="card-body">
<h2 className="card-title">
Expand Down

0 comments on commit 9e9d6a4

Please sign in to comment.