Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p2p): disable peer discovery for the sequencer #923

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

srene
Copy link
Contributor

@srene srene commented Jun 19, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--
This PR is aimed at disabling p2p automatic connectivity using p2p dht discovery. in current version it is possible to disable advertising in the dht, but since the node is still discovering other nodes via DHT, there are connections automatically generated by the dht. therefore even if disabling dht advertising the result is lack of control of p2p connections.
this pr changes this behaviour by replacing disabling only advertising, by disable dht itself. therefore a node that do not want to start p2p connections other than manually configured (e.g sequencer using sentries) can use this option.
this option also disables blocksync, since makes use of the dht

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #981

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner June 19, 2024 07:15
@srene srene marked this pull request as draft June 19, 2024 07:15
@srene srene self-assigned this Jan 28, 2025
@srene srene marked this pull request as ready for review January 28, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p2p: add an option to disable DHT node discovery
1 participant