feat(p2p): disable peer discovery for the sequencer #923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
Opening a pull request should be able to meet the following requirements
--
This PR is aimed at disabling p2p automatic connectivity using p2p dht discovery. in current version it is possible to disable advertising in the dht, but since the node is still discovering other nodes via DHT, there are connections automatically generated by the dht. therefore even if disabling dht advertising the result is lack of control of p2p connections.
this pr changes this behaviour by replacing disabling only advertising, by disable dht itself. therefore a node that do not want to start p2p connections other than manually configured (e.g sequencer using sentries) can use this option.
this option also disables blocksync, since makes use of the dht
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #981
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: