-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(da): improvements in avail da with availability check #1357
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a question about batch unmrashalling
da/avail/avail.go
Outdated
@@ -239,7 +259,10 @@ func (c *DataAvailabilityLayerClient) RetrieveBatches(daPath string) da.ResultRe | |||
data = data[1:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't we say we don't go byte by byte cause the intrinsic should be correct? i.e if we fail first byte assuming it's our intrinsic than there is a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is the avoid the issue of extra bytes appended to the beginning of the blob (not added in this pr). the extra bytes are not part of the blob submitted, so its correct to disregard them.
what i added is, once an unmarshable blob is found, check the hash of it is the same compared to what was submitted. the intrinsic only provides appid info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in any case its been replaced by new avail-go-sdk and filtered by signer. so only submitted blobs by sequencer are returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about the batch unmrashaling bytes traversing. afair we said the intrinsic should indicate it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about the batch unmrashaling bytes traversing. afair we said the intrinsic should indicate it.
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: