Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(celestia): don't wait for DA readiness to start the sequencer #1337

Merged
merged 26 commits into from
Feb 3, 2025
Merged

fix(celestia): don't wait for DA readiness to start the sequencer #1337

merged 26 commits into from
Feb 3, 2025

Conversation

srene
Copy link
Contributor

@srene srene commented Jan 17, 2025 •
edited
Loading

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #1336

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Jan 17, 2025
@srene srene requested a review from a team as a code owner January 17, 2025 14:57
@srene srene marked this pull request as draft January 17, 2025 14:57
srene
srene commented Jan 23, 2025
View reviewed changes
da/da.go
@@ -237,11 +237,8 @@ type DataAvailabilityLayerClient interface {
// CheckBatchAvailability checks the availability of the blob submitted getting proofs and validating them
CheckBatchAvailability(daMetaData *DASubmitMetaData) ResultCheckBatch

// Used to check when the DA light client finished syncing
WaitForSyncing()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waitforsyncing is removed since its no longer necesasry to wait for the light client to be synced to submit and validate blob inclusion in celestia

@srene srene marked this pull request as ready for review January 23, 2025 17:01
@srene srene marked this pull request as draft January 23, 2025 17:06
@srene srene marked this pull request as ready for review January 23, 2025 19:36
@srene srene changed the title feat(celestia): remove celestia openrpc dependency refactor(celestia): remove celestia openrpc dependency Jan 24, 2025
@srene srene linked an issue Jan 24, 2025 that may be closed by this pull request
celestia openrpc is deprecated #1336
Closed
@omritoptix omritoptix linked an issue Jan 27, 2025 that may be closed by this pull request
proposer should not wait for DA readiness #1254
Closed
@omritoptix omritoptix changed the title refactor(celestia): remove celestia openrpc dependency fix(celestia): don't wait for DA readiness to start the sequencer Jan 29, 2025
@omritoptix omritoptix merged commit 60f03aa into main Feb 3, 2025
4 checks passed
@omritoptix omritoptix deleted the srene/celestia-refactor branch February 3, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees

@srene srene

Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

celestia openrpc is deprecated proposer should not wait for DA readiness
2 participants
@srene @omritoptix