feat(l2 fork): Handle fork #1199
Conversation
# Conflicts: # block/manager.go # mocks/github.com/dymensionxyz/dymint/settlement/mock_ClientI.go
…nsition # Conflicts: # block/executor.go # block/manager.go
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
block/fork.go
Outdated
| panic(fmt.Sprintf("produce empty block: %v", err)) | ||
| } | ||
|
|
||
| err = m.applyBlock(block, commit, types.BlockMetaData{Source: types.Produced}) |
There was a problem hiding this comment.
is there any reason to not gossip these two blocks to the p2p?
There was a problem hiding this comment.
if there is no specific reason to not gossiping the blocks, i would call the already existing ProduceApplyGossipBlock() func.
…l-node-transition
…hard-fork-full-node-transition
| } | ||
|
|
||
| if m.shouldStopNode(rollapp, lastBlock) { | ||
| err = m.createInstruction(rollapp) |
There was a problem hiding this comment.
will be called every LoopInterval = 15 * time.Second until manual reboot?
the freezeNode doesn't freeze this loop
| // 2. If the block's app version (equivalent to revision) is less than the rollapp's revision | ||
| func (m *Manager) shouldStopNode(rollapp *types.Rollapp, block *types.Block) bool { | ||
| revision := block.Header.Version.App | ||
| if m.State.Height() >= rollapp.RevisionStartHeight && revision < rollapp.Revision { |
There was a problem hiding this comment.
why we need to check the lastBlock? isn't redundant with m.State.Height()?
There was a problem hiding this comment.
where is the last block?
There was a problem hiding this comment.
block *types.Block in the arg
lastBlock, err := m.Store.LoadBlock(m.State.Height())
if err != nil {
return err
}
if m.shouldStopNode(rollapp, lastBlock) {
```
| @@ -23,8 +23,8 @@ import ( | |||
| const minBlockMaxBytes = 10000 | |||
|
|
|||
| type ExecutorI interface { | |||
| CreateBlock(height uint64, lastCommit *types.Commit, lastHeaderHash, nextSeqHash [32]byte, state *types.State, maxBlockDataSizeBytes uint64, enforceEmpty bool) *types.Block | |||
There was a problem hiding this comment.
enforceEmpty i think it can be removed because not used
| ) *types.Block { | ||
| maxBlockDataSizeBytes = min(maxBlockDataSizeBytes, uint64(max(minBlockMaxBytes, state.ConsensusParams.Block.MaxBytes))) | ||
| mempoolTxs := e.mempool.ReapMaxBytesMaxGas(int64(maxBlockDataSizeBytes), state.ConsensusParams.Block.MaxGas) | ||
|
|
There was a problem hiding this comment.
enforceEmpty is always false so it can be removed
block/fork.go
Outdated
| panic(fmt.Sprintf("produce empty block: %v", err)) | ||
| } | ||
|
|
||
| err = m.applyBlock(block, commit, types.BlockMetaData{Source: types.Produced}) |
There was a problem hiding this comment.
if there is no specific reason to not gossiping the blocks, i would call the already existing ProduceApplyGossipBlock() func.
|
closing in favor of #1212 |
PR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #XXX
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: