Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed code duplication in delayed ack middleware #559

Closed
wants to merge 52 commits into from

Conversation

omritoptix
Copy link
Contributor

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpeted math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (omritoptix/490-eibc-v1@1bfc91c). Click here to learn what that means.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             omritoptix/490-eibc-v1     #559   +/-   ##
=========================================================
  Coverage                          ?   30.53%           
=========================================================
  Files                             ?      198           
  Lines                             ?    28358           
  Branches                          ?        0           
=========================================================
  Hits                              ?     8659           
  Misses                            ?    18306           
  Partials                          ?     1393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix changed the title refactor: refactor delay ack middleware refactor: removed code duplication in delayed ack middleware Feb 15, 2024
Base automatically changed from omritoptix/490-eibc-v1 to main February 19, 2024 17:32
@omritoptix omritoptix closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant