Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Audit fixes round 2 #511

Merged
merged 7 commits into from
Jan 28, 2024
Merged

fix: Audit fixes round 2 #511

merged 7 commits into from
Jan 28, 2024

Conversation

mtsitrin
Copy link
Contributor

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin requested a review from omritoptix January 25, 2024 16:22
@mtsitrin mtsitrin requested a review from a team as a code owner January 25, 2024 16:22
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (bb59edf) 30.80% compared to head (001fe5c) 30.87%.

Files Patch % Lines
app/ante/reject_msgs.go 50.00% 11 Missing and 2 partials ⚠️
app/ante/handlers.go 20.00% 12 Missing ⚠️
app/healthcheck.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
+ Coverage   30.80%   30.87%   +0.06%     
==========================================
  Files         166      166              
  Lines       25340    25383      +43     
==========================================
+ Hits         7806     7836      +30     
- Misses      16288    16299      +11     
- Partials     1246     1248       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix merged commit 080cf5a into main Jan 28, 2024
4 checks passed
@omritoptix omritoptix deleted the audit_fixes_v2 branch January 28, 2024 08:10
@omritoptix omritoptix changed the title chore: Audit fixes round 2 fix: Audit fixes round 2 Jan 28, 2024
omritoptix pushed a commit that referenced this pull request Jan 29, 2024
omritoptix pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants