refactor(lightclient): removed the need for next stateInfo for valiadition #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1406) Co-authored-by: keruch <[email protected]> Co-authored-by: zale144 <[email protected]> Co-authored-by: Daniel T <[email protected]> Co-authored-by: Omri <[email protected]> Co-authored-by: Sergi Rene <[email protected]> Co-authored-by: Itzhak Bokris <[email protected]>
Base automatically changed from
mtsitrin/937-rollapp-hard-fork-hub-side
to
main
November 14, 2024 14:29
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 22.69% 22.69% -0.01%
==========================================
Files 575 575
Lines 124579 124516 -63
==========================================
- Hits 28273 28257 -16
+ Misses 92528 92494 -34
+ Partials 3778 3765 -13 ☔ View full report in Codecov by Sentry. |
danwt
approved these changes
Jan 10, 2025
Comment on lines
+75
to
+81
| func (s *StateInfo) NextSequencerForHeight(height uint64) string { | ||
| if height != s.GetLatestHeight() { | ||
| return s.Sequencer | ||
| } | ||
| return s.NextProposer | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| func (s *StateInfo) NextSequencerForHeight(height uint64) string { | |
| if height != s.GetLatestHeight() { | |
| return s.Sequencer | |
| } | |
| return s.NextProposer | |
| } | |
| func (s *StateInfo) Successor(height uint64) string { | |
| if height != s.GetLatestHeight() { | |
| return s.Sequencer | |
| } | |
| return s.NextProposer | |
| } | |
|
Great job |
agree |
mtsitrin
deleted the
1308-xlightclient-redundent-call-for-findstateinfobyheight
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRY out the validation methods into 2:
ValidateHeaderAgainstStateInfo- validates LC updated against existing state infoValidateStateInfoAgainstConsensusStates- validates State Info against existing consensus statesmain changes:
on
HandleMsgUpdateClienton
SetCanonicalClient