refactor(compiler): Don't emit class and style bindings on structural…

… template views The Template Pipeline has had a number of tricky bugs involving bindings on structural elements. Consider this template: ``` <div *ngIf="true" [class.bar]="field"></div> ``` We were incorrectly emitting `ɵɵclassProp` on *both* the template's view, and the inner view. The solution is to just emit an extracted attribute on the enclosing template, so it still shows up in the const array, but does not affect the update block. We should look to refactor binding ingestion soon.
dylhunn · Dec 8, 2023 · ecff426 · ecff426
1 parent 95099d4
commit ecff426
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...er-cli/test/compliance/test_cases/r3_view_compiler_styling/class_bindings/TEST_CASES.json b/...er-cli/test/compliance/test_cases/r3_view_compiler_styling/class_bindings/TEST_CASES.json
@@ -69,8 +69,7 @@
             "class_binding_on_structural.js"
           ]
         }
-      ],
-      "skipForTemplatePipeline": true
+      ]
     }
   ]
 }
diff --git a/packages/compiler/src/template/pipeline/src/ingest.ts b/packages/compiler/src/template/pipeline/src/ingest.ts
@@ -903,7 +903,8 @@ function ingestBinding(
   }
 
   if (flags & BindingFlags.OnNgTemplateElement && !(flags & BindingFlags.BindingTargetsTemplate) &&
-      type === e.BindingType.Property) {
+      (type === e.BindingType.Property || type === e.BindingType.Class ||
+       type === e.BindingType.Style)) {
     // This binding only exists for later const extraction, and is not an actual binding to be
     // created.
     view.create.push(ir.createExtractedAttributeOp(
-Original file line number
+Diff line change
@@ Expand Up / @@ -69,8 +69,7 @@ @@
                 "class_binding_on_structural.js"
               ]
             }
-          ],
-          "skipForTemplatePipeline": true
+          ]
         }
       ]
     }