refactor(compiler): Fix extra attribute on ng-template (angular#53405)

We no longer emit extra attribute instructions on certain `ng-template` elements with attributes. PR Close angular#53405
dylhunn · Dec 8, 2023 · 8ab7e84 · 8ab7e84
1 parent 90e0908
commit 8ab7e84
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_template/TEST_CASES.json b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_template/TEST_CASES.json
@@ -366,8 +366,7 @@
         {
           "failureMessage": "Incorrect template"
         }
-      ],
-      "skipForTemplatePipeline": true
+      ]
     },
     {
       "description": "should handle attribute bindings inside an ng-template",
@@ -378,8 +377,7 @@
         {
           "failureMessage": "Incorrect template"
         }
-      ],
-      "skipForTemplatePipeline": true
+      ]
     }
   ]
 }
diff --git a/packages/compiler/src/template/pipeline/src/ingest.ts b/packages/compiler/src/template/pipeline/src/ingest.ts
@@ -794,6 +794,7 @@ function ingestBindings(
         attr.i18n);
     hasI18nAttributes ||= attr.i18n !== undefined;
   }
+
   for (const input of element.inputs) {
     ingestBinding(
         unit, op.xref, input.name, input.value, input.type, input.unit, input.securityContext,
@@ -927,6 +928,12 @@ function ingestBinding(
     expression = value;
   }
 
+  if (type === e.BindingType.Attribute && !(flags & BindingFlags.TextValue) &&
+      templateKind === ir.TemplateKind.Structural) {
+    // TODO: big comment about why this is stupid.
+    return;
+  }
+
   const kind: ir.BindingKind = BINDING_KINDS.get(type)!;
   view.update.push(ir.createBindingOp(
       xref, kind, name, expression, unit, securityContext, !!(flags & BindingFlags.TextValue),