Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bonsai-ui): filter for null/0 prices #1459

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Jan 23, 2025

No description provided.

@jaredvu jaredvu requested a review from a team as a code owner January 23, 2025 19:14
Copy link

linear bot commented Jan 23, 2025

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:17pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 7:17pm

@@ -124,8 +125,11 @@ export const useMarketsData = ({
.filter(isTruthy)
.sort(sortByMarketCap)
.map((asset) => {
// Remove assets that are already in the list of markets from Indexer
if (marketsAssetIdSet.has(asset.assetId)) return null;
// Remove assets that are already in the list of markets from Indexer a long with assets that have no price or a negative price
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: along

@jaredvu jaredvu merged commit 0b320d2 into main Jan 23, 2025
8 of 9 checks passed
@jaredvu jaredvu deleted the jared/bug2-245-baby-doge-and-harris-popular-vote-are-showing-up-in-the-new branch January 23, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants