Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(withdraw-modal): use account delta hook to display diffs #1429

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Jan 14, 2025

Screen Shot 2025-01-13 at 5 42 20 PM

Display account diffs and reset address field if chain is incompatible.


Views

  • <WithdrawDialog>

    • add side effect to erase address field
  • <WithdrawForm>

    • add <Details> for account diffs

Constants/Types

  • constants/chains
    • add walletNetworkType to CHAIN_INFO struct

@jaredvu jaredvu requested a review from a team as a code owner January 14, 2025 01:42
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:27pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 11:27pm

tyleroooo
tyleroooo previously approved these changes Jan 15, 2025
Copy link
Contributor

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, lets hold off and not merge into the feature branch though

Base automatically changed from jv/subaccount-operations-2 to main January 15, 2025 21:58
@jaredvu jaredvu dismissed tyleroooo’s stale review January 15, 2025 21:58

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants