feat: deposit modal form invalid states #1415
Merged
+127
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredvu
reviewed
Jan 8, 2025
Comment on lines
80
to
82
| <div tw="text-center"> | ||
| There was an error. Please increase your deposit amount and try again. | ||
| </div> |
There was a problem hiding this comment.
do you think we should use <AlertMessage> component? Or does it stray too far from your ideal design
There was a problem hiding this comment.
gonna amend this in a bit actually, dan gave me new designs
jaredvu
reviewed
Jan 8, 2025
| <Button | ||
| tw="w-full" | ||
| state={ButtonState.Disabled} | ||
| disabled | ||
| state={depositDisabled ? ButtonState.Disabled : ButtonState.Default} |
There was a problem hiding this comment.
state={{ isDisabled: depositDisabled, isLoading: isFetching }}
jaredvu
reviewed
Jan 8, 2025
Comment on lines
53
to
55
| const depositButtonInner = useMemo(() => { | ||
| if (isFetching) return <LoadingDots size={3} />; | ||
| if (!hasSufficientBalance) return `Insufficient ${getTokenSymbol(token.denom)}`; |
There was a problem hiding this comment.
the insufficient balance message?
jaredvu
approved these changes
Jan 13, 2025
…ance-check-deposit
jaredvu
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insufficient token:
Deposit amount too small (designs not finalized just placeholder for now):
