Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: noUncheckedIndexedAccess #1180

Merged
merged 8 commits into from
Oct 21, 2024
Merged

chore: noUncheckedIndexedAccess #1180

merged 8 commits into from
Oct 21, 2024

Conversation

tyleroooo
Copy link
Contributor

No description provided.

@tyleroooo tyleroooo requested a review from a team as a code owner October 18, 2024 20:51
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 5:50pm
v4-testnet 🛑 Canceled (Inspect) Oct 21, 2024 5:50pm

Copy link
Contributor

@tinaszheng tinaszheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

scripts/markets/add-markets.ts Outdated Show resolved Hide resolved
scripts/markets/help.ts Show resolved Hide resolved
src/hooks/tradingView/useChartMarketAndResolution.ts Outdated Show resolved Hide resolved
src/hooks/transfers/skipClient.tsx Outdated Show resolved Hide resolved
src/hooks/useAffiliatesInfo.ts Show resolved Hide resolved
src/lib/assetUtils.ts Show resolved Hide resolved
src/lib/notifications.ts Outdated Show resolved Hide resolved
src/lib/numbers.ts Show resolved Hide resolved
src/lib/orderModification.ts Outdated Show resolved Hide resolved
src/lib/skip.ts Outdated Show resolved Hide resolved

// Chart state
const getClampedZoomDomain = useCallback(
(unclamped: number) => {
return clamp(
Math.max(1e-320, Math.min(Number.MAX_SAFE_INTEGER, unclamped)),
minZoomDomain,
xAccessor(latestDatum) - xAccessor(earliestDatum)
atLeastOnePoint ? xAccessor(latestDatum!) - xAccessor(earliestDatum!) : 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be added to dep array?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing a bunch of stuff downstream of data but depends on data so it should be fine I think.

@tyleroooo tyleroooo merged commit e081b82 into main Oct 21, 2024
9 of 10 checks passed
@tyleroooo tyleroooo deleted the tu/turn-on-implicit-access branch October 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants