feat: add previous page to navigatePage [OTE-768] #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tyleroooo
approved these changes
Oct 17, 2024
| const previousPath = previousPathRef.current; | ||
| track(AnalyticsEvents.NavigatePage({ path: location.pathname, previousPath })); | ||
| previousPathRef.current = location.pathname; | ||
| } | ||
| }, [location]); |
There was a problem hiding this comment.
should this be location.pathname ?
There was a problem hiding this comment.
hmm yeah that makes sense. 🤔 can fix later though so we don't have to re-approve this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a ref to track the previous location pathname outside of the react lifecycle. if people are spooked by this i'm happy to use another approach but it feels pretty stable to me