Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query subaccounts from smart contract #995

Closed
wants to merge 1 commit into from

Conversation

dydxwill
Copy link
Contributor

Changelist

query subaccounts from smart contract

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

@dydxwill dydxwill changed the base branch from main to 2024-hackathon-cosmwasm January 19, 2024 18:55
Copy link
Contributor

coderabbitai bot commented Jan 19, 2024

Walkthrough

The changes involve integrating CosmWasm into a blockchain protocol, enabling smart contract functionality. A Dockerfile is updated to use a specific library version, ensuring its integrity and configuration for static linking. The app.go file sees the addition of a new WasmKeeper, function modifications, and CosmWasm module integration. The basic_manager.go and module_accounts.go files are updated to support Wasm. New contracts and infrastructure for dYdX messages and a hackathon are added, including Docker and CI configurations, smart contract templates, and Wasm bindings for handling dYdX-specific operations.

Changes

Files Change Summary
protocol/Dockerfile Updated to add and configure a specific library version for static linking.
protocol/app/app.go Imports added, WasmKeeper declared, overrideWasmVariables function added, CosmWasm module integrated.
protocol/app/basic_manager/basic_manager.go wasm package added as an AppModuleBasic.
protocol/app/module_accounts.go New import for wasmtypes, updated module account permissions.
protocol/contracts/... New files for Wasm projects including Docker, CI configs, coding styles, workflows, development environment setup, and documentation for smart contracts.
protocol/contracts/.../src/* Functionality added for contracts to interact with the dYdX protocol and hackathon module, including instantiation, execution, and state management.
protocol/dydx-cosmwasm/... Configuration, documentation, and source files added for the dYdX CosmWasm protocol, including message handling and protocol-specific data structures.
protocol/wasmbinding/* Functionality introduced for CosmWasm support, handling messages and queries related to dYdX operations.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@@ -9,10 +9,11 @@ mod response_helper;
pub use msg::{DydxMsg, SubaccountId, Transfer, Order, OrderSide, OrderTimeInForce, OrderConditionType, OrderId};
pub use querier::DydxQuerier;
pub use query::{
DydxQuery, DydxQueryWrapper,
DydxQuery, DydxQueryWrapper, SubaccountResponse,
};
// TODO: Export MarketPriceResponse instead for style consistency.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TODO comment on line 14 indicates that MarketPriceResponse should be exported for style consistency. This should be addressed to maintain a consistent interface.

Would you like me to open a GitHub issue to track this task?

@dydxwill dydxwill closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant