Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IND-500]: Create Aggregate trading rewards roundtable task outline #917

Merged
merged 3 commits into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import {
dbHelpers, testMocks,
} from '@dydxprotocol-indexer/postgres';

describe('aggregate-trading-rewards', () => {
beforeAll(async () => {
await dbHelpers.migrate();
await dbHelpers.clearData();
});

beforeEach(async () => {
await testMocks.seedData();
});

afterEach(async () => {
await dbHelpers.clearData();
jest.resetAllMocks();
});

afterAll(async () => {
await dbHelpers.teardown();
});
Comment on lines +5 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lifecycle hooks for setting up and tearing down the test environment are well-defined. However, there are no actual test cases defined within the describe block. Ensure that test cases are added to validate the functionality of the aggregate-trading-rewards task.


it('temp', () => {
expect(true).toEqual(true);
});
});
4 changes: 4 additions & 0 deletions indexer/services/roundtable/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export const configSchema = {
LOOPS_ENABLED_UPDATE_RESEARCH_ENVIRONMENT: parseBoolean({ default: false }),
LOOPS_ENABLED_TRACK_LAG: parseBoolean({ default: false }),
LOOPS_ENABLED_REMOVE_OLD_ORDER_UPDATES: parseBoolean({ default: true }),
LOOPS_ENABLED_AGGREGATE_TRADING_REWARDS: parseBoolean({ default: true }),

// Loop Timing
LOOPS_INTERVAL_MS_MARKET_UPDATER: parseInteger({
Expand Down Expand Up @@ -74,6 +75,9 @@ export const configSchema = {
LOOPS_INTERVAL_MS_REMOVE_OLD_ORDER_UPDATES: parseInteger({
default: THIRTY_SECONDS_IN_MILLISECONDS,
}),
LOOPS_INTERVAL_MS_AGGREGATE_TRADING_REWARDS: parseInteger({
default: ONE_MINUTE_IN_MILLISECONDS,
}),

// Start delay
START_DELAY_ENABLED: parseBoolean({ default: true }),
Expand Down
9 changes: 9 additions & 0 deletions indexer/services/roundtable/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
redisClient,
connect as connectToRedis,
} from './helpers/redis';
import aggregateTradingRewardsTasks from './tasks/aggregate-trading-rewards';
import cancelStaleOrdersTask from './tasks/cancel-stale-orders';
import createPnlTicksTask from './tasks/create-pnl-ticks';
import deleteZeroPriceLevelsTask from './tasks/delete-zero-price-levels';
Expand Down Expand Up @@ -121,6 +122,14 @@ async function start(): Promise<void> {
);
}

if (config.LOOPS_ENABLED_AGGREGATE_TRADING_REWARDS) {
startLoop(
aggregateTradingRewardsTasks,
'aggregate_trading_rewards',
config.LOOPS_INTERVAL_MS_AGGREGATE_TRADING_REWARDS,
);
}

logger.info({
at: 'index',
message: 'Successfully started',
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
import {
BlockFromDatabase,
BlockTable,
TradingRewardFromDatabase,
} from '@dydxprotocol-indexer/postgres';
import { DateTime } from 'luxon';

/**
* Task: Aggregate Trading Rewards
* Description: This task aggregates trading rewards for a specific period of time.
* It retrieves trading data from the database, calculates the rewards, and stores the aggregated
* results.
*/
interface Interval {
start: DateTime;
end: DateTime;
}

interface SortedTradingRewardData {
[address: string]: TradingRewardFromDatabase[];
}

export default async function runTask(): Promise<void> {
// TODO(IND-499): Add resetting aggregation data when cache is empty
const interval: Interval | undefined = await getTradingRewardDataToProcessInterval();

const tradingRewardData: TradingRewardFromDatabase[] = await getTradingRewardDataToProcess(
interval,
);
const sortedTradingRewardData: SortedTradingRewardData = sortTradingRewardData(tradingRewardData);
await updateTradingRewardsAggregation(sortedTradingRewardData);
// TODO(IND-499): Update AggregateTradingRewardsProcessedCache
}

async function getTradingRewardDataToProcessInterval(): Promise<Interval> {
const latestBlock: BlockFromDatabase = await BlockTable.getLatest();

// TODO(IND-499): Setup AggregateTradingRewardsProcessedCache for start time and add end time
return {
start: DateTime.fromISO(latestBlock.time),
end: DateTime.fromISO(latestBlock.time),
};
}

async function getTradingRewardDataToProcess(
_interval: Interval,
): Promise<TradingRewardFromDatabase[]> {
// TODO: Implement
return Promise.resolve([]);
}

function sortTradingRewardData(
_tradingRewardData: TradingRewardFromDatabase[],
): SortedTradingRewardData {
// TODO: Implement
return {};
}

async function updateTradingRewardsAggregation(
_sortedTradingRewardData: SortedTradingRewardData,
): Promise<void> {
// TODO: Implement
}