-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update commit scripts #893
Conversation
WalkthroughThe script updates involve modifications to environment account assignments within deployment scripts. The Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- indexer/scripts/deploy-commit-to-env.sh (1 hunks)
- indexer/scripts/push-commit-to-ecr.sh (1 hunks)
Files skipped from review due to trivial changes (1)
- indexer/scripts/push-commit-to-ecr.sh
Additional comments: 1
indexer/scripts/deploy-commit-to-env.sh (1)
- 26-27: The addition of account assignments for "public-testnet" and "mainnet" environments is correctly implemented in the case statement. However, ensure that the account numbers provided (
013339450148
for "public-testnet" and332066407361
for "mainnet") are valid and have the necessary permissions for deployment.
"dev4") account=525975847385;; | ||
"dev5") account=917958511744;; | ||
"staging") account=677285201534;; | ||
"public-testnet") account=013339450148;; # public testnet | ||
"mainnet") account=332066407361;; # mainnet | ||
*) account=329916310755;; | ||
esac | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-29]
The script's comments and usage instructions should be updated to include the new environments "public-testnet" and "mainnet". This will help users understand that these environments are now supported and can be used as valid arguments when running the script.
# To run the script, use the following command:
# scripts/deploy-commit-to-env.sh <service> <commit> <dev|dev2|dev3|dev4|dev5|staging|public-testnet|mainnet>
# For example:
# scripts/deploy-commit-to-env.sh comlink 875aecd staging
Changelist
Update commit scripts
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.