Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commit scripts #893

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Update commit scripts #893

merged 1 commit into from
Dec 15, 2023

Conversation

Christopher-Li
Copy link
Contributor

Changelist

Update commit scripts

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Copy link
Contributor

coderabbitai bot commented Dec 14, 2023

Walkthrough

The script updates involve modifications to environment account assignments within deployment scripts. The deploy-commit-to-env.sh script now includes account assignments for both "public-testnet" and "mainnet" environments. Additionally, the push-commit-to-ecr.sh script has been altered to replace "testnet3" with "mainnet," updating the associated account number accordingly. These changes streamline the deployment process for different environments by ensuring the correct AWS accounts are used.

Changes

Files Changes
indexer/scripts/deploy-commit-to-env.sh Added account assignments for "public-testnet" and "mainnet" environments.
indexer/scripts/push-commit-to-ecr.sh Replaced "testnet3" with "mainnet" in account assignment, updating account number from 013339450148 to 332066407361.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between eba7f81 and 7cfe882.
Files selected for processing (2)
  • indexer/scripts/deploy-commit-to-env.sh (1 hunks)
  • indexer/scripts/push-commit-to-ecr.sh (1 hunks)
Files skipped from review due to trivial changes (1)
  • indexer/scripts/push-commit-to-ecr.sh
Additional comments: 1
indexer/scripts/deploy-commit-to-env.sh (1)
  • 26-27: The addition of account assignments for "public-testnet" and "mainnet" environments is correctly implemented in the case statement. However, ensure that the account numbers provided (013339450148 for "public-testnet" and 332066407361 for "mainnet") are valid and have the necessary permissions for deployment.

Comment on lines 23 to 30
"dev4") account=525975847385;;
"dev5") account=917958511744;;
"staging") account=677285201534;;
"public-testnet") account=013339450148;; # public testnet
"mainnet") account=332066407361;; # mainnet
*) account=329916310755;;
esac

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-29]

The script's comments and usage instructions should be updated to include the new environments "public-testnet" and "mainnet". This will help users understand that these environments are now supported and can be used as valid arguments when running the script.

# To run the script, use the following command:
#   scripts/deploy-commit-to-env.sh <service> <commit> <dev|dev2|dev3|dev4|dev5|staging|public-testnet|mainnet>
# For example:
#   scripts/deploy-commit-to-env.sh comlink 875aecd staging

@Christopher-Li Christopher-Li merged commit 0d121a7 into main Dec 15, 2023
11 checks passed
@Christopher-Li Christopher-Li deleted the cl_update_scripts branch December 15, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants