Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOB-1046] populate negative tnc subaccounts in grpc request #890

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

jayy04
Copy link
Contributor

@jayy04 jayy04 commented Dec 13, 2023

Changelist

  • populate block height and negative tnc subaccounts in liquidation daemon grpc request.

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Copy link

linear bot commented Dec 13, 2023

Copy link
Contributor

coderabbitai bot commented Dec 13, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

…892)

* [CLOB-1047] populate subaccounts with open positions in grpc request

* comments
@jayy04 jayy04 merged commit 2294683 into jy/clob-1043 Dec 18, 2023
16 of 17 checks passed
@jayy04 jayy04 deleted the jy/clob-1046 branch December 18, 2023 20:50
jayy04 added a commit that referenced this pull request Dec 19, 2023
* [CLOB-1043] replicate IsLiquidatable logic on daemon

* comments

* comments

* update to return error

* [CLOB-1044] replicate funding settlement on liquidation daemon (#882)

* [CLOB-1043] deprecate unused grpc query (#889)

* [CLOB-1043] deprecate unused grpc query

* fix lint

* [CLOB-1046] populate negative tnc subaccounts in grpc request (#890)

* [CLOB-1046] populate negative tnc subaccounts in grpc request

* [CLOB-1047] populate subaccounts with open positions in grpc request (#892)

* [CLOB-1047] populate subaccounts with open positions in grpc request

* comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants