-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-824] Implement keeper methods for LimitParams
and DenomCapacity
#877
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ export const createRPCMsgClient = async ({ | |
clob: new (await import("./clob/tx.rpc.msg")).MsgClientImpl(rpc), | ||
delaymsg: new (await import("./delaymsg/tx.rpc.msg")).MsgClientImpl(rpc), | ||
feetiers: new (await import("./feetiers/tx.rpc.msg")).MsgClientImpl(rpc), | ||
ibcratelimit: new (await import("./ibcratelimit/tx.rpc.msg")).MsgClientImpl(rpc), | ||
ratelimit: new (await import("./ratelimit/tx.rpc.msg")).MsgClientImpl(rpc), | ||
perpetuals: new (await import("./perpetuals/tx.rpc.msg")).MsgClientImpl(rpc), | ||
prices: new (await import("./prices/tx.rpc.msg")).MsgClientImpl(rpc), | ||
rewards: new (await import("./rewards/tx.rpc.msg")).MsgClientImpl(rpc), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The verification process has revealed that the
Analysis chainThe change from I will correct the script to properly verify the existence of the new import path and to ensure that the commands for searching for references to I will adjust the script to specifically check for the I will verify the existence of the Scripts ExecutedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Verify the new import path exists.
fd 'tx.rpc.msg.ts' --exec test -f {} \; -a -d 'src/codegen/dydxprotocol/ratelimit'
# Search for any remaining references to the old module name.
rg 'ibcratelimit'
# Verify that the old property is not used anymore.
ast-grep --lang typescript --pattern $'ibcratelimit: new (await import("./ibcratelimit/tx.rpc.msg")).MsgClientImpl($_)'
Length of output: 372 Script: #!/bin/bash
# Corrected command to verify the new import path exists by checking for the file within the specified directory.
fd 'tx.rpc.msg.ts' --exec sh -c 'test -f {} && echo {} is present' \;
# Re-run the search for any remaining references to the old module name to confirm the lack of output.
rg 'ibcratelimit'
# Re-run the ast-grep command to confirm that the old property is not used anymore.
ast-grep --lang typescript --pattern $'ibcratelimit: new (await import("./ibcratelimit/tx.rpc.msg")).MsgClientImpl($_)'
Length of output: 1255 Script: #!/bin/bash
# Adjusted command to specifically check for the tx.rpc.msg.ts file within the ratelimit directory.
fd 'tx.rpc.msg.ts' --exec sh -c 'test -f {} && echo {} is present' \; | grep 'ratelimit/tx.rpc.msg.ts'
# Verify the presence of the new ratelimit property to ensure the replacement is complete.
ast-grep --lang typescript --pattern $'ratelimit: new (await import("./ratelimit/tx.rpc.msg")).MsgClientImpl($_)'
Length of output: 308 Script: #!/bin/bash
# Directly check for the existence of the ratelimit/tx.rpc.msg.ts file.
test -f ./indexer/packages/v4-protos/src/codegen/dydxprotocol/ratelimit/tx.rpc.msg.ts && echo "ratelimit/tx.rpc.msg.ts is present" || echo "ratelimit/tx.rpc.msg.ts is not present"
# Confirm the accuracy of the ast-grep command for the new ratelimit property.
ast-grep --lang typescript --pattern $'ratelimit: new (await import("./ratelimit/tx.rpc.msg")).MsgClientImpl($_)'
Length of output: 289 |
||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verification process has revealed that the
query.lcd.ts
file is still located within theibcratelimit
directory, not theratelimit
directory as would be expected following the PR's objectives and summary. This suggests that the file may not have been correctly renamed or moved according to the changes described in the PR. Please verify the implementation of the file renaming and movement to align with the module reorganization.query.lcd.ts
file is located in theibcratelimit
directory instead of theratelimit
directory.Analysis chain
The addition of the
ratelimit
property to thecreateLCDClient
function's return object is consistent with the PR's objectives and the renaming of the module. Ensure that the new import path./ratelimit/query.lcd
is correct and that the file exists.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 228
Script:
Length of output: 148