-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename TradingRewardEventV1 name and denom field #869
Conversation
WalkthroughThe recent updates involve renaming entities and fields in TypeScript interfaces and protocol buffer definitions related to trading rewards. The term Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- protocol/indexer/events/events.pb.go
Files selected for processing (2)
- indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts (9 hunks)
- proto/dydxprotocol/indexer/events/events.proto (2 hunks)
Files skipped from review due to trivial changes (1)
- proto/dydxprotocol/indexer/events/events.proto
Additional comments: 8
indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts (8)
1134-1141: The changes from lines 1134 to 1141 correctly reflect the renaming of the
TradingRewardEventV1
interface toTradingRewardsEventV1
as per the PR objectives and summary.1157-1164: The changes from lines 1157 to 1164 correctly reflect the renaming of the
denoms
field todenomAmount
within theAddressTradingReward
interface, aligning with the PR objectives and summary.1172-1179: The changes from lines 1172 to 1179 correctly reflect the renaming of the
denoms
field todenom_amount
within theAddressTradingRewardSDKType
interface, which is consistent with the renaming pattern applied to the non-SDK type interface.2902-2915: The changes from lines 2902 to 2915 introduce the
TradingRewardsEventV1
interface, which is consistent with the renaming pattern and the PR objectives. ThetradingRewards
field is correctly typed as an array ofAddressTradingReward
.2947-2952: The changes from lines 2947 to 2952 introduce the
AddressTradingReward
interface with theowner
anddenomAmount
fields, which aligns with the renaming of thedenoms
field todenomAmount
as per the PR objectives.2957-2964: The changes from lines 2957 to 2964 correctly implement the
encode
method for theAddressTradingReward
interface, ensuring theowner
anddenomAmount
fields are encoded when they are not default values.2978-2984: The changes from lines 2978 to 2984 correctly implement the
decode
method for theAddressTradingReward
interface, ensuring theowner
anddenomAmount
fields are decoded from the input.2993-2998: The changes from lines 2993 to 2998 correctly implement the
fromPartial
method for theAddressTradingReward
interface, which is used to create a partial instance of the interface from an object.
Changelist
Rename TradingRewardEventV1 name and denom field
Test Plan
Field is not used, no tests
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.