-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IND-520] Add more pnl stats #826
Conversation
WalkthroughThe changes made to the Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts (6 hunks)
Additional comments: 10
indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts (10)
1-1: The import of 'stats' is correctly added to support the new timing metrics.
39-39: The local variable 'startGetPnlTicksCreateObjects' is correctly added to capture the start time for timing metrics.
51-54: The timing metric for 'get_ticks_relevant_accounts' is correctly implemented to measure the duration of the relevant accounts retrieval.
74-77: The timing metric for 'get_ticks_accounts_to_update' is correctly implemented to measure the duration of the accounts to update retrieval.
82-82: The local variable 'getFundingIndexStart' is correctly added to capture the start time for timing metrics.
89-92: The timing metric for 'get_ticks_funding_indices' is correctly implemented to measure the duration of the funding indices retrieval.
94-94: The local variable 'getAccountInfoStart' is correctly added to capture the start time for timing metrics.
140-143: The timing metric for 'get_ticks_account_info' is correctly implemented to measure the duration of the account information retrieval.
145-145: The local variable 'computePnlStart' is correctly added to capture the start time for timing metrics.
162-165: The timing metric for 'get_ticks_compute_pnl' is correctly implemented to measure the duration of the pnl computation.
Changelist
Add more timing stats to pnl calculation
Test Plan
metrics
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.