Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IND-520] Add more pnl stats #826

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[IND-520] Add more pnl stats #826

merged 2 commits into from
Dec 1, 2023

Conversation

dydxwill
Copy link
Contributor

Changelist

Add more timing stats to pnl calculation

Test Plan

metrics

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Copy link
Contributor

coderabbitai bot commented Nov 30, 2023

Walkthrough

The changes made to the pnl-ticks-helper.ts file in the indexer services for the roundtable project involve the addition of timing metrics to various functions. These metrics are intended to monitor the performance of different parts of the process that calculates profit and loss (PnL) ticks. The update includes importing a statistics module, initializing timing variables, and recording the duration of specific operations such as retrieving relevant accounts, updating accounts, fetching funding indices, getting account information, and computing PnL.

Changes

File Path Changes
.../roundtable/src/helpers/pnl-ticks-helper.ts Added import for 'stats', added timing metrics for various functions including 'get_ticks_relevant_accounts', 'get_ticks_accounts_to_update', 'get_ticks_funding_indices', 'get_ticks_account_info', and 'get_ticks_compute_pnl'.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 66073c1 and 5f728bb.
Files selected for processing (1)
  • indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts (6 hunks)
Additional comments: 10
indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts (10)
  • 1-1: The import of 'stats' is correctly added to support the new timing metrics.

  • 39-39: The local variable 'startGetPnlTicksCreateObjects' is correctly added to capture the start time for timing metrics.

  • 51-54: The timing metric for 'get_ticks_relevant_accounts' is correctly implemented to measure the duration of the relevant accounts retrieval.

  • 74-77: The timing metric for 'get_ticks_accounts_to_update' is correctly implemented to measure the duration of the accounts to update retrieval.

  • 82-82: The local variable 'getFundingIndexStart' is correctly added to capture the start time for timing metrics.

  • 89-92: The timing metric for 'get_ticks_funding_indices' is correctly implemented to measure the duration of the funding indices retrieval.

  • 94-94: The local variable 'getAccountInfoStart' is correctly added to capture the start time for timing metrics.

  • 140-143: The timing metric for 'get_ticks_account_info' is correctly implemented to measure the duration of the account information retrieval.

  • 145-145: The local variable 'computePnlStart' is correctly added to capture the start time for timing metrics.

  • 162-165: The timing metric for 'get_ticks_compute_pnl' is correctly implemented to measure the duration of the pnl computation.

@dydxwill dydxwill changed the title Add more pnl stats [IND-520] Add more pnl stats Dec 1, 2023
Copy link

linear bot commented Dec 1, 2023

@dydxwill dydxwill merged commit 5b49c90 into main Dec 1, 2023
11 checks passed
@dydxwill dydxwill deleted the wl/pnl_stats branch December 1, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants