Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fees to fills Athena DDL table. #824

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

vincentwschau
Copy link
Contributor

Changelist

Add fee column to fills table Athena DDL.

Test Plan

Unit tests.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

@vincentwschau vincentwschau added the bug Something isn't working label Nov 30, 2023
Copy link
Contributor

coderabbitai bot commented Nov 30, 2023

Walkthrough

The update involves the addition of a new "fee" column to the Athena database tables related to fills. This column has been incorporated into two constants that define the table schemas, ensuring that the new fee data will be included in both the raw and transformed table structures. The function for generating the raw table has not been modified, indicating that the addition of the new column does not affect the table creation logic.

Changes

File Path Change Summary
.../roundtable/src/lib/athena-ddl-tables/fills.ts Added "fee" column of type string to RAW_TABLE_COLUMNS and TABLE_COLUMNS.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 66073c1 and a4a1543.
Files selected for processing (1)
  • indexer/services/roundtable/src/lib/athena-ddl-tables/fills.ts (2 hunks)
Additional comments: 3
indexer/services/roundtable/src/lib/athena-ddl-tables/fills.ts (3)
  • 22-26: The addition of the fee column to RAW_TABLE_COLUMNS is consistent with the summary and appears to be correctly formatted.

  • 40-44: The addition of the fee column to TABLE_COLUMNS is consistent with the summary and appears to be correctly formatted.

  • 47-47: The generateRawTable function remains unchanged, which is consistent with the summary.

@vincentwschau vincentwschau merged commit 207b903 into main Nov 30, 2023
11 checks passed
@vincentwschau vincentwschau deleted the vincentc/add-fees-to-fills-athena-ddl branch November 30, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working indexer
Development

Successfully merging this pull request may close these issues.

3 participants