Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick changes for indexer v1.0.2 #787

Merged
merged 18 commits into from
Nov 10, 2023
Merged

Cherry-pick changes for indexer v1.0.2 #787

merged 18 commits into from
Nov 10, 2023

Conversation

vincentwschau
Copy link
Contributor

Changelist

Cherry-picked changes for indexer v1.0.2.

Test Plan

Will test in staging.

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Christopher-Li and others added 18 commits November 9, 2023 21:56
@Christopher-Li @vincentwschau
[IND-171]: Do not send subaccount websocket message for unplaced and …
5a28087 
…unreplaced BEST_EFFORT_CANCELED orders (#716)
@Christopher-Li @vincentwschau
[IND-458]: In case of errors in comlink log request (#722)
f564c79
@lcwik @vincentwschau
Fix order handler to return correct updatedAt/updatedAtHeight (#733)
567423a 
Also rename functions to have dydx_ prefix to allow for script deletion to successfully remove and update these functions during ender deployment.
@lcwik @vincentwschau
[IND-465] Add support for liquidation handler to use a single SQL fun…
af09034 
…ction. Also fix fill and order models since clientMetadata is a nullable field. (#734)

* [IND-465] Add support for liquidation handler to use a single SQL function.

Also fix fill model since clientMetadata is a nullable field and the database already reflects that it is nullable.
@lcwik @vincentwschau
[IND-467] Push ender market create logic to use a single sql function (…
d7376bd 
…#737)

* [IND-467] Push ender market create logic to use a single sql function
@lcwik @vincentwschau
[IND-468] Push ender market modify logic to use a single SQL function (…
e4ed18b 
…#745)

* [IND-468] Push ender market modify logic to use a single SQL function
@lcwik @vincentwschau
[IND-469] Update ender market price update handler to execute updat…
680779e 
…es via a SQL function. (#746)
@lcwik @vincentwschau
[IND-470] Update asset create handler to use SQL function. (#748)
b3d3132
@lcwik @vincentwschau
[IND-475] Update ender update clob pair handler to execute via a SQ…
88b6d24 
…L function. (#752)

* [IND-475] Update ender `update clob pair` handler to execute via a SQL function.
@lcwik @vincentwschau
[IND-476] Update ender update perpetual handler to execute updates vi…
3713d55 
…a a SQL function. (#755)

* [IND-476] Update ender update perpetual handler to execute updates via a SQL function.
@lcwik @vincentwschau
[IND-473] Update ender perpetual market create to execute updates via…
2433894 
… a SQL function. (#760)
@lcwik @vincentwschau
[IND-472] Update ender liquidity tier upsert to execute updates via a…
69ed5ec 
… SQL function. (#761)
@Christopher-Li @vincentwschau
[IND-450]: Prevent orders transitioning from canceled to best effort …
77b5707 
…canceled (#753)

* [IND-450]: Prevent orders transitioning from canceled to best effort canceled

* fix liquidations

* nits

* lint
@lcwik @vincentwschau
[IND-474] Update ender transfer handler to execute updates via a SQL …
d61033d 
…function. (#763)
@vincentwschau
[IND-442] Don't send cancel messages if orders are fully filled in st…
26eb1ad 
…ate. (#754)
@lcwik @vincentwschau
[IND-471] Update ender funding to execute updates via a SQL function. (…
ba2de87 
…#770)
@Christopher-Li @vincentwschau
[IND-482]: Send timing fields for orders when possible (#768)
73bd546 
* [IND-482]: Send timing fields for orders when possible

* nit and fix test
@lcwik @vincentwschau
[IND-477, IND-478, IND-479, IND-480] Update all stateful order handle…
31cc1af 
…rs to use a SQL function to perform reads & updates. (#774)
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@vincentwschau vincentwschau merged commit 6f25fac into release/indexer/v1.x Nov 10, 2023
11 checks passed
@vincentwschau vincentwschau deleted the vincentc/cherry-pick-indexer-1-0-2 branch November 10, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roy-dydx roy-dydx roy-dydx approved these changes

@dydxwill dydxwill dydxwill approved these changes

Assignees
No one assigned
Labels
indexer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vincentwschau @dydxwill @roy-dydx @Christopher-Li @lcwik